#2211 new
Aaron D. Campbell

Fill image doesn't pass a "valid"

Reported by Aaron D. Campbell | April 7th, 2013 @ 11:54 PM

This is a different issue form the previous ticket: https://shopp.lighthouseapp.com/projects/47561-shopp/tickets/2210-C...

In core/image.php in ImageServer::request() where the parameters are exploded on comma the last parameter is popped off to use as a validator. The problem is that fill images don't pass this parameter, so it pops off the height. In my case I was sending 250,375 and getting back a 250x250 image. I added a check to only pop the last parameter off into $this->valid if there are more than two parameters, assuming that two parameters are width,height.

It would probably be safer to move the regex that fills $this->request above the parameters processing and use the if ('000' == substr($this->request,0,3)) check, but this way worked for me for now.

Comments and changes to this ticket

Please Sign in or create a free account to add a new ticket.

With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.

New-ticket Create new ticket

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile ยป

Plugin e-commerce for WordPress

Shared Ticket Bins

People watching this ticket