#1536 ✓ closed
Clifton Griffin

shopp('checkout','offline-instructions') tag seemingly absent from 1.2

Reported by Clifton Griffin | February 13th, 2012 @ 08:58 PM | in 1.2.1 (closed)

Whilst troubleshooting this help ticket:
https://shopplugin.net/support/topic/shopp-12-payment-settings-offl...

I determined that the shopp('checkout','offline-instructions') tag is seemingly absent in 1.2.

Environment

WordPress Version: 3.3.1
Shopp Version: 1.2

Comments and changes to this ticket

  • Jonathan

    Jonathan March 5th, 2012 @ 11:40 AM

    • State changed from “new” to “open”
    • Tag set to payment gateways, bug
    • Milestone set to 1.2.1
    • Milestone order changed from “717” to “0”
  • Barry Hughes

    Barry Hughes March 5th, 2012 @ 12:38 PM

    Also interested in this one (this support ticket relates) so here are some further notes:

    • Customer chooses the offline payment option
    • Order is confirmed and thanks.php is displayed
    • The offline instructions are displayed only if the shopp('purchase','notpaid') condition is met
    • In turn, a check is made within ShoppPurchaseThemeAPI::paid() to see if 'authed' or 'captured' are present in the $txnstatus array
    • 'authed' is indeed present and so shopp('purchase','notpaid') returns false and shopp('checkout','offline-instructions') is not then executed
  • Barry Hughes

    Barry Hughes March 5th, 2012 @ 12:40 PM

    Just to add, moving shopp('checkout','offline-instructions') outside of the if shopp('purchase','notpaid') { /* ... */ } isn't a workaround here - I'm guessing the context that would lead to the offline-instructions tag being registered does not exist at that point?

  • Jonathan

    Jonathan March 9th, 2012 @ 04:48 PM

    • Assigned user set to “Jonathan”
    • Milestone order changed from “16” to “0”
  • Jonathan

    Jonathan March 12th, 2012 @ 11:18 AM

    Partially addressed with revision #2963

  • Jonathan

    Jonathan March 12th, 2012 @ 11:19 AM

    • State changed from “open” to “closed”

    (from [2969]) Fixed Order controller to correctly select the order processor based on the available payment options instead of selecting the activate processors and locating the payment option it belongs to, fixes [#1536 state:closed]

  • Jonathan

    Jonathan March 12th, 2012 @ 11:23 AM

    The problem is in some cases two-fold.

    The shopp('purchase','paid') call was seeing authed as a valid "paid" status. That was preventing the message from appearing on the thanks.php content template.

    Secondarily, a bug in the Order controller prevented the proper default selection of the Offline Payment instance related to payment method selected, so either no instructions were available or were incorrect.

  • Jonathan

    Jonathan February 16th, 2013 @ 05:01 PM

    (from [b0bfe4765ab6]) Fixed Order controller to correctly select the order processor based on the available payment options instead of selecting the activate processors and locating the payment option it belongs to, fixes [#1536 state:closed]

    git-svn-id: file:///Users/jond/svngit/svnrepos/shopp/trunk@2969 846ab242-8549-0410-9a75-dfdbdae9473e

    https://bitbucket.org/ingenesis/shopp/changeset/b0bfe4765ab6/

Please Sign in or create a free account to add a new ticket.

With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.

New-ticket Create new ticket

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile »

Plugin e-commerce for WordPress

Shared Ticket Bins